>>/1236/
> shebang is wrong.
#!/bin/sh
what is wrong with the way I've done it? This is on the first line of all of the .sh scripts, or have I missed something? Did I miss this on a file?
I think that I'm doing this incorrectly with the .py files, as most scripts I've seen use /usr/bin/env python
while I point to /usr/bin/python which is a soft link to python2 or python3. I can change this if this is what you're talking about.
> bashisms.
The BSD ports that are placed in the BSD folder were all tested on OpenBSD SH and were modified until they worked. I haven't updated these files in like a year or so, but they don't use any bash at all. There are no bash-isms in winstream.bat, although it's implemented inefficiently and needs an update / fix.
Can you give me an example of one of the bash-isms from my scripts ? Name the script and the number line(s), and offer an alternative notation. If I agree I'll fix it/ change it.
This is more of a style complaint, its important , but functionality and logic are more important to me. Namely that it works, and that it does what it's functionally supposed to do, and that the way that it does the task is correct (process steps are correct). Style is tertiary in importance for me here, but it's not unimportant.
This is a hobby for me, and I'm not a professional computer scientist or software developer. I know that there are many experts out there that will take issue with my code, but if it worked for me, then I shared it. I had an idea, implemented it, it worked for me, and so I shared it. You're free to modify it as you see fit.
Thanks for the constructive criticism and feedback, it is helpful.